jake
/
elseware
1
0
Fork 0
Code Issues 63 Pull Requests 1 Projects Releases Wiki Activity
Labels Milestones
New Issue

perf issue around EntityGateway #115

Closed
opened 2 years ago by jake · 1 comments
jake commented 2 years ago
Owner

so due to all my passing around of the singular entity gateway structure I am pretty sure I am hilariously limiting myself to only 1 db transaction at a time like a total moron.

InMemoryGateway and PostgreGateway are both designed to be Clone but due to my PEAK ITEMREFACTOR I had to remove that trait to get transactions to work.

not that this used to be fast. for that to happen I would need to pass a clone of the gateway into the handler functions rather than a reference to the main one.

so due to all my passing around of the singular entity gateway structure I am pretty sure I am hilariously limiting myself to only 1 db transaction at a time like a total moron. `InMemoryGateway` and `PostgreGateway` are both designed to be `Clone` but due to my PEAK ITEMREFACTOR I had to remove that trait to get transactions to work. not that this used to be fast. for that to happen I would need to pass a clone of the gateway into the handler functions rather than a reference to the main one.
jake closed this issue 2 years ago
jake commented 2 years ago
Poster
Owner

closed by #117

closed by http://git.sharnoth.com/jake/elseware/pulls/117
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
andy/add-patch-log-dir
andy/clamp-mag-feed
andy/directories
andy/map-objects
andy/update-rust
expsteal
fuckin_andy_making_me_do_this_now
kill_counters
map_objects
master
morfin/test
move_stuff_to_libpso
pbs
presents
sendgc
set_char_exp
teams
techs
traps
unitxt
Labels
Apply labels
Clear labels
item refactor nice to have one day maybe someday release
No Label item refactor nice to have one day maybe someday release
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes