jake/elseware
1
0
Fork 0
Code Issues 63 Pull Requests 1 Projects Releases Wiki Activity

perf issue around EntityGateway #115

New Issue
Closed
opened 2022-07-28 18:50:37 -04:00 by jake · 1 comment
jake commented 2022-07-28 18:50:37 -04:00
Owner
Copy Link

so due to all my passing around of the singular entity gateway structure I am pretty sure I am hilariously limiting myself to only 1 db transaction at a time like a total moron.

InMemoryGateway and PostgreGateway are both designed to be Clone but due to my PEAK ITEMREFACTOR I had to remove that trait to get transactions to work.

not that this used to be fast. for that to happen I would need to pass a clone of the gateway into the handler functions rather than a reference to the main one.

so due to all my passing around of the singular entity gateway structure I am pretty sure I am hilariously limiting myself to only 1 db transaction at a time like a total moron. `InMemoryGateway` and `PostgreGateway` are both designed to be `Clone` but due to my PEAK ITEMREFACTOR I had to remove that trait to get transactions to work. not that this used to be fast. for that to happen I would need to pass a clone of the gateway into the handler functions rather than a reference to the main one.
jake closed this issue 2022-07-30 23:48:53 -04:00
jake commented 2022-07-30 23:49:09 -04:00
Author
Owner
Copy Link

closed by #117

closed by http://git.sharnoth.com/jake/elseware/pulls/117
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
item refactor
nice to have
one day maybe someday
release
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
andy chimpyroadkill cmw252 morfin reason jake
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jake/elseware#115
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?