jake/elseware
1
0
Fork 0
Code Issues 63 Pull Requests 1 Projects Releases Wiki Activity

patch server doesnt empty it's list of patches #94

New Issue
Open
opened 2022-02-12 21:13:11 -05:00 by andy · 1 comment
andy commented 2022-02-12 21:13:11 -05:00
Collaborator
Copy Link

when a client connects to the patch server and sends FileInfoReply (client telling the server it's info about the patch file(s) sent by the patch server), the patch server is collecting this list and not emptying it.

http://git.sharnoth.com/jake/elseware/src/branch/master/src/patch/patch.rs#L186

eventually Something Bad will happen to the patch server since the PatchServerState.patch_file_info vec is increasing infinitely, and maybe logins will become increasingly delayed since the patch server is validating more and more files as each client connects.

when a client connects to the patch server and sends `FileInfoReply` (client telling the server it's info about the patch file(s) sent by the patch server), the patch server is collecting this list and not emptying it. http://git.sharnoth.com/jake/elseware/src/branch/master/src/patch/patch.rs#L186 eventually Something Bad will happen to the patch server since the `PatchServerState.patch_file_info` vec is increasing infinitely, and maybe logins will become increasingly delayed since the patch server is validating more and more files as each client connects.
andy added the
release
 label 2022-02-14 17:17:57 -05:00
jake commented 2022-02-14 20:19:51 -05:00
Owner
Copy Link

HAHA OOPS

HAHA OOPS
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
item refactor
nice to have
one day maybe someday
release
No Label
release
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
andy chimpyroadkill cmw252 morfin reason jake
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jake/elseware#94
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?