jake
/
elseware
1
0
Fork 0
Code Issues 63 Pull Requests 1 Projects Releases Wiki Activity
Labels Milestones
New Issue

patch server doesnt empty it's list of patches #94

Open
opened 3 years ago by andy · 1 comments
andy commented 3 years ago
Collaborator

when a client connects to the patch server and sends FileInfoReply (client telling the server it's info about the patch file(s) sent by the patch server), the patch server is collecting this list and not emptying it.

http://git.sharnoth.com/jake/elseware/src/branch/master/src/patch/patch.rs#L186

eventually Something Bad will happen to the patch server since the PatchServerState.patch_file_info vec is increasing infinitely, and maybe logins will become increasingly delayed since the patch server is validating more and more files as each client connects.

when a client connects to the patch server and sends `FileInfoReply` (client telling the server it's info about the patch file(s) sent by the patch server), the patch server is collecting this list and not emptying it. http://git.sharnoth.com/jake/elseware/src/branch/master/src/patch/patch.rs#L186 eventually Something Bad will happen to the patch server since the `PatchServerState.patch_file_info` vec is increasing infinitely, and maybe logins will become increasingly delayed since the patch server is validating more and more files as each client connects.
andy added the
release
 label 3 years ago
jake commented 3 years ago
Owner

HAHA OOPS

HAHA OOPS
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
andy/add-patch-log-dir
andy/clamp-mag-feed
andy/directories
andy/map-objects
andy/update-rust
expsteal
fuckin_andy_making_me_do_this_now
kill_counters
map_objects
master
morfin/test
move_stuff_to_libpso
pbs
presents
sendgc
set_char_exp
teams
techs
traps
unitxt
Labels
Apply labels
Clear labels
item refactor nice to have one day maybe someday release
No Label item refactor nice to have one day maybe someday release
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(MISSING)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes