shop_sell #47

Closed
andy wants to merge 0 commits from shop_sell into master
andy commented 3 years ago
Collaborator

nice warez u got there

nice warez u got there
andy added 13 commits 3 years ago
jake requested changes 3 years ago
return Some(10u32)
}
// other item factors?
Some((WeaponShopItem::weapon_from_item(w).price() / 8) as u32)
jake commented 3 years ago
Poster
Owner

this (and other x_from_item) should be impl From<WeaponDetail> for WeaponShopItem. then the code here be w.into().price() / 8 (which might not work due to type inference not inferring enough but should still use standard From trait)

this (and other `x_from_item`) should be `impl From<WeaponDetail> for WeaponShopItem`. then the code here be `w.into().price() / 8` (which might not work due to type inference not inferring enough but should still use standard `From` trait)
sold_item_handle.consume(amount)?;
},
// TODO: put a real error here
Ordering::Greater => {println!("i can't believe you've done this.");},
jake commented 3 years ago
Poster
Owner

ItemMangerError::InvalidSale

`ItemMangerError::InvalidSale`
andy added 2 commits 3 years ago
66d882d336 cleanup todos
andy added 1 commit 3 years ago
b60463eaa0 appease the clip
andy closed this pull request 3 years ago
jake requested changes 3 years ago
}
}
pub fn get_sell_price(&self) -> Result<u32, ItemManagerError> {
jake commented 3 years ago
Poster
Owner

this made more sense returning an Option I think

this made more sense returning an `Option` I think

Reviewers

jake requested changes 3 years ago
Some checks failed
continuous-integration/drone/push Build is failing
Required
Details
continuous-integration/drone/pr Build is failing
Required
Details
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.